Pull Request Review and GitHub Members

This document describes the procedure that the people in the “sunpy-maintainers” group must follow when merging a pull request. If in any doubt about merging a pull request, the correct course of action is to contact the Lead Developer and ask.

Each pull request must meet the following criteria before it is considered for merge:

  • The code must be PEP 8 compliant and meet the ill-defined SunPy quality standards. We have these in the Coding Standards page.

  • The PR must contain a CHANGELOG entry if it changes the behavior of any code.

  • The test coverage should not decrease, and for new features should be at or very close to 100%.

  • All code must be properly documented. Each function and each class must have an associated documentation string in the correct format.

Review Process

Before the “merge” button is clicked the following criteria must be met:

  • All the continuous integration must pass unless there is a known issue.

  • At least two members (not the author of the PR) of the “sunpy-developers” group must have approved the PR, one should be a relevant subpackage maintainer.

  • All comments posted on the thread must be resolved.

It is important that approval for merging the PR is done on the comment thread, as this becomes part of the “permanent record”, this includes in during community meetings or in chat.

Continuous Integration

Currently we have a variety of services that respond or activate on an opened pull request.

Comments from bots:

  • pep8speaks: Performs a PEP8 check on any submitted code. This is updated as the code changes.

Checks that appear at the bottom of a pull request:

PR checks

or at the top under the “Checks” tab:

PR checks tab
  • figure-tests (CircleCi): Runs two figure tests environments (“py38-figure”, “py37-figure-devdeps”).

  • figure_report/figure_tests (Giles): Show the final results of the figure tests.

  • figure_report_devdeps (Giles): Show the final results of the figure tests using development packages.

  • changelog: absent | found (Giles): If a changelog is needed, this will check and will pass if a changelog with the correct number is found.

  • milestone: absent | present (Giles): Will check that the pull request has a milestone assigned.

  • docs/readthedocs.org:sunpy (Read the Docs): This builds our documentation. This primary check is to ensure the documentation has rendered correctly. Warnings are not checked on this build but under Azure Pipelines (see below).

  • sunpy.sunpy (Azure Pipelines): Runs our test suite on all three operating systems. There are 11 separate checks for this.

  • codecov/patch (CodeCov): Checks how many lines of the code lack test coverage for the submitted code in the pull request.

  • codecov/project (CodeCov): Checks how many lines of the code lack test coverage in sunpy overall.

It is common to see some of these checks fail. This can be happen due to a change that has broken a test (should be fixed) or a remote server has failed (might have to wait for it to come back). Therefore it is important to check why a task failed and if has a pre-existing issue, it can be safe to ignore a failing check on that pull request. However, you should try to ensure that as many checks pass before merging.

Understanding Azure Pipelines

The vast majority of our tests are run on Azure Pipelines and this means you might have to navigate to the results if you want to check why the tests failed.

The Azure checks on GitHub manifest:

PR checks tab

This is the main form. There will be one check per Azure job ran, and a summary one called “sunpy.sunpy”. The details text will redirect you to the “Checks” tab.

Doing so will show:

Summary of Azure outputs on Checks tab

You get some statistics that you don’t need to worry about and then a series of boxes under the “ANNOTATIONS” heading. Unfortunately, when a Azure step fails you sometimes will get “Bash exited with code ‘1’.” which means you have to go to the page to see what happened. If the failure is due to a test, you will get a selection of test outputs under this heading.

On the left you should see the entire list of Azure checks. You can go to a failing check and you will see:

Go to Azure Pipelines

which will take you to the Azure Pipelines website. This will load up the following:

Build steps in Azure

Here you can see each step that is undertaken during a job on Azure. Normally the “Running tox” should be red if the tests have failed. You will need to click on this so it will load the output from the test suite.

Our test suite is very verbose, so there will be a lot of text outputted. The important bits of information should be at the bottom as “pytest” prints out a test summary at the end. For example:

============================================================================= short test summary info =============================================================================
SKIPPED [1] d:\a\1\s\.tox\py37\lib\site-packages\pytest_doctestplus\plugin.py:178: unable to import module local('d:\\a\\1\\s\\.tox\\py37\\lib\\site-packages\\sunpy\\io\\setup_package.py')
SKIPPED [213] d:\a\1\s\.tox\py37\lib\site-packages\pytest_remotedata\plugin.py:87: need --remote-data option to run
SKIPPED [18] d:\a\1\s\.tox\py37\lib\site-packages\_pytest\doctest.py:387: all tests skipped by +SKIP option
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\map\sources\tests\test_source_type.py:21: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\map\sources\tests\test_source_type.py:30: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_ana.py:22: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_ana.py:31: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_ana.py:40: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_ana.py:49: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_ana.py:58: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_ana.py:67: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_filetools.py:54: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_filetools.py:73: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_filetools.py:106: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_filetools.py:115: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_filetools.py:122: ANA is not available.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_jp2.py:11: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_jp2.py:21: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\io\tests\test_jp2.py:31: Glymur can not be imported.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\net\tests\test_fido.py:298: Windows.
SKIPPED [1] .tox\py37\lib\site-packages\sunpy\net\tests\test_helioviewer.py:90: Glymur can not be imported.
FAILED ..\..\.tox\py37\lib\site-packages\sunpy\timeseries\sources\noaa.py::sunpy.timeseries.sources.noaa.NOAAGoesSXRTimeSeries

If you want to find the full test output, you can search the tab for the name of the test out of the ~3 results, one will be that output.

SunPy GitHub Groups

This document has already referred to two SunPy groups, namely “developers” and “maintainers” there is also a third primary SunPy group “owners”. These owners’ have control over the means of production.

SunPy owners

The SunPy owners group is the group of people who have total control over the SunPy GitHub organization. The SunPy board have control over who is in this group, it has been decided that generally it will be the Lead Developer and the SunPy board chair and vice-chair.

SunPy Maintainers

This is the group of people who have push access to the main SunPy repository. The membership of this group is at the discretion of the Lead Developer, but shall generally be made up of people who have demonstrated themselves to be trust worthy and active contributors to the project.

This group has subgroups for each section of the repository that has maintainers. The members of these groups will automatically be requested to review all PRs which change files in that subpackage.

SunPy Developers

The members of this group have “read” access to the SunPy repository. As all these repository are open anyway, what this effectively means is that these people can be assigned to issues. The members of this group are people who are involved in the development of SunPy at a good frequency, they are people who’s opinions have been demonstrated to be constructive and informative.